Changes between Version 194 and Version 195 of LnDevel

Timestamp:

Sep 19, 2024, 11:44:01 AM (12 hours ago)

Author:

lnerger

Comment:

--

LnDevel

@@ -207 +207 @@
 
 Major Changes and additions:
- * Performance improvements to ''PDAFomi_init_dim_obs_l''. While we already improve the performance in V2.2.1 we found that by further restructuring of the code the performance could be further improved. (In some cases with gfortran and ifort compilers by a factor of 6 to 9.) The previous routine is still present as PDAFomi_init_dim_obs_l_old. 
- * For even better performance of the initialization of local observations, we added ''support for a user-sided implementation of search for local observations''. The user-sided search routine can lead to the best performance since it requires less IF-checks which are required in the generic code inside PDAFomi. If you have the impression that PDAFomi_init_dim_obs_l is slow in your case, e.g. because it domines the run time of the analysis step, we recommend to aim for a user-sided implementation (see https://pdaf.awi.de/trac/wiki/OMI_search_local_observations)
  * Addition of ''support for non-diagonal observation error covariance matrices in PDAF-OMI'' (see https://pdaf.awi.de/trac/wiki/OMI_nondiagonal_observation_error_covariance_matrices)
  * ''Introduction of PDAFlocal interface''. This simplifies the implementation of the state localization. It also provides support for weighted local increments, e.g. to implement vertical localization or weakly coupled assimilation. (see https://pdaf.awi.de/trac/wiki/PDAFlocal_overview)
+ * ''Performance improvements to PDAFomi_init_dim_obs_l''. While we already improved the performance in V2.2.1 we found that we can further improve the performance by further restructuring of the code. (In some cases with gfortran and ifort compilers by a factor of 6 to 10.) The previous routine is still present as PDAFomi_init_dim_obs_l_old. 
+ * For even better performance of the initialization of local observations, we added ''support for implementing a user-provided alternative to PDAFomi_init_dim_obs_l''. The user-provided routine can lead to the best performance since it requires less IF-checks, which are required in the generic code inside PDAFomi. If you have the impression that PDAFomi_init_dim_obs_l is still slow in your case, e.g. because it dominates the run time of the analysis step, we recommend to aim for a user-sided implementation (see https://pdaf.awi.de/trac/wiki/OMI_search_local_observations). 
+
 
 Further changes and additions:
- * Improved ''parser_mpi.F90'': Now parsing a slash '/' is possible. This now also allows to parse directory paths. In addition, for string parsing it is checked if the string is truncated upon parsing.
+ * Improved ''parser_mpi.F90'': Now parsing a slash '/' is possible. This now also allows to parse directory paths. In addition, for string parsing it is checked if the string is truncated upon parsing. All files parser_mpi.F90 in the different directories of the PDAF package are updated.
  * Update of ''PDAF_diag_crps'': The routine now includes parallelization. There is a separate routine ''PDAF_diag_crps_mpi'' which allows one to specify the communicator in which the operation is performed. 
- * New ''Makefile'' in PDAF root directory. This makefile performs the compilation in the directory build/ and keeps src/ clear. Further, it supports parallel compilation.  The previous Makefile in src/ is still present, but will be removed in a future release. If you integrated the compilation of PDAF in some larger build process, we recommend to switch to the new Makefile. (The new makefile requires to the set variable 'MODULEOPT' in the compiler-specific include file in make.arch/. This variable specifies the compiler option fo rthe directory where compiled .mod files are to be stored) 
+ * New ''Makefile'' in the PDAF root directory. This makefile performs the compilation in the directory build/ and keeps src/ clean. Further, it supports parallel compilation.  The previous Makefile in src/ is still present, but will be removed in a future release. If you integrated the compilation of PDAF in some larger build process, we recommend to switch to the new Makefile. (The new makefile requires to the set the variable 'MODULEOPT' in the compiler-specific include file in make.arch/. This variable specifies the compiler option for the directory where compiled .mod files are to be stored) 
  * New routine ''PDAFomi_observation_localization_weights'' as convenient way to get a localization weight. Usable for example in the prodRinvA or likelihood routines for non-diagonal R.
  * New routine ''PDAF_correlation_function'' to provide the value of correlation functions. Currently, a Gaussian and the 5th-order polynomial by Gaspari&Cohn (1999) are implemented.
@@ -221 +222 @@
  
 Bug fixes:
- * Replace lower-case letters by upper case in TRTRS library calls. This circumvents a bug in some versions of OPENBLAS, which causes OPENBLAS to only accept upper case letters for this call. 
+ * Replace lower-case letters by upper case in TRTRS library calls. This circumvents a bug in some versions of OPENBLAS, which causes OPENBLAS to only accept upper-case letters for this call. 
  * Revision of ETKF/ESTKF/SEIK analysis step. For domains with dim_obs_p=0 now the observation operator is called consistently with domains having dim_obs_p>0. This allows for global MPI operations in the observation operator routine.